Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(new-ticker): Improve accessibility - FRONT-3662 #2570

Merged
merged 16 commits into from
Jun 28, 2022
Merged

fix(new-ticker): Improve accessibility - FRONT-3662 #2570

merged 16 commits into from
Jun 28, 2022

Conversation

papegaill
Copy link
Contributor

@papegaill papegaill commented Jun 17, 2022 •
edited
Loading

  • fix tab key flow + deactivate focus on hidden slides (inert + tabindex='-1' as a fallback)
  • add play & pause buttons instead of only a toggle autoplay button
  • pause ticker on mouseover
  • disable autoplay if focus is on a slide CTA
  • if only one slide, hide controls and don't initialize ticker
  • add ellipsis for more than 2 lines
  • update ticker styles:
    • update blue background color for both EC and EU variant
    • review position of the controls for each breakpoint,
    • controls hover, active and focus stats

@papegaill papegaill requested a review from a team June 17, 2022 16:00
@github-actions
Copy link

github-actions bot commented Jun 17, 2022 •
edited
Loading

🚀 Deployed on https://ecl-preview-2570--europa-component-library.netlify.app

@emeryro emeryro merged commit 7cb249b into v3.4.0-dev Jun 28, 2022
@emeryro emeryro deleted the fix/FRONT-3662 branch June 28, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emeryro emeryro emeryro approved these changes

Assignees
No one assigned
Labels
tag: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@papegaill @emeryro